Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor binding env test #1567

Merged
merged 11 commits into from
Dec 12, 2024
Merged

Refactor binding env test #1567

merged 11 commits into from
Dec 12, 2024

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Dec 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • move binding_envtest unit tests to internal/broker
  • those tests are not covering http API
  • only necessary test cases are using envteset (not all)

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Dec 11, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 11, 2024
@piotrmiskiewicz piotrmiskiewicz force-pushed the refactor-binding-env-test branch from a12e1be to 9d798e7 Compare December 12, 2024 07:26
@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review December 12, 2024 07:27
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner December 12, 2024 07:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) December 12, 2024 07:27
@piotrmiskiewicz piotrmiskiewicz added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Dec 12, 2024
@piotrmiskiewicz piotrmiskiewicz force-pushed the refactor-binding-env-test branch from cd48448 to d56538b Compare December 12, 2024 13:53
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 12, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 83ca704 into kyma-project:main Dec 12, 2024
28 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrmiskiewicz @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot